Skip to content

feat(ecs): Managed Instances Infrastructure Optimization #45142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(ecs): Managed Instances Infrastructure Optimization #45142

wants to merge 4 commits into from
+163 −4

Conversation

@kg-aws
Copy link
Contributor

@kg-aws kg-aws commented Nov 19, 2025 •
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Description

New Feature: ECS Managed Instances Infrastructure Optimization

Relations

References

https://docs.aws.amazon.com/AmazonECS/latest/developerguide/managed-instances-infrastructure-optimization.html

Output from Acceptance Testing

make t T=TestAccECSCapacityProvider_ K=ecs P=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 managed_instances_infra_optimization 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/ecs/... -v -count 1 -parallel 2 -run='TestAccECSCapacityProvider_'  -timeout 360m -vet=off
2025/11/20 10:05:57 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/20 10:05:57 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccECSCapacityProvider_Identity_Basic
=== PAUSE TestAccECSCapacityProvider_Identity_Basic
=== RUN   TestAccECSCapacityProvider_Identity_RegionOverride
=== PAUSE TestAccECSCapacityProvider_Identity_RegionOverride
=== RUN   TestAccECSCapacityProvider_Identity_ExistingResource
=== PAUSE TestAccECSCapacityProvider_Identity_ExistingResource
=== RUN   TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
=== PAUSE TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
=== RUN   TestAccECSCapacityProvider_basic
=== PAUSE TestAccECSCapacityProvider_basic
=== RUN   TestAccECSCapacityProvider_disappears
=== PAUSE TestAccECSCapacityProvider_disappears
=== RUN   TestAccECSCapacityProvider_managedScaling
=== PAUSE TestAccECSCapacityProvider_managedScaling
=== RUN   TestAccECSCapacityProvider_managedScalingPartial
=== PAUSE TestAccECSCapacityProvider_managedScalingPartial
=== RUN   TestAccECSCapacityProvider_tags
=== PAUSE TestAccECSCapacityProvider_tags
=== RUN   TestAccECSCapacityProvider_clusterFieldValidations
=== PAUSE TestAccECSCapacityProvider_clusterFieldValidations
=== RUN   TestAccECSCapacityProvider_mutualExclusivity
=== PAUSE TestAccECSCapacityProvider_mutualExclusivity
=== RUN   TestAccECSCapacityProvider_createManagedInstancesProvider_basic
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_basic
=== RUN   TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements
=== RUN   TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration
=== RUN   TestAccECSCapacityProvider_updateManagedInstancesProvider
=== PAUSE TestAccECSCapacityProvider_updateManagedInstancesProvider
=== RUN   TestAccECSCapacityProvider_createManagedInstancesProvider_withInfrastructureOptimization
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_withInfrastructureOptimization
=== CONT  TestAccECSCapacityProvider_Identity_Basic
=== CONT  TestAccECSCapacityProvider_tags
--- PASS: TestAccECSCapacityProvider_Identity_Basic (47.47s)
=== CONT  TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements
--- PASS: TestAccECSCapacityProvider_tags (86.23s)
=== CONT  TestAccECSCapacityProvider_createManagedInstancesProvider_withInfrastructureOptimization
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements (38.84s)
=== CONT  TestAccECSCapacityProvider_updateManagedInstancesProvider
--- PASS: TestAccECSCapacityProvider_updateManagedInstancesProvider (52.78s)
=== CONT  TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_withInfrastructureOptimization (65.36s)
=== CONT  TestAccECSCapacityProvider_basic
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration (38.01s)
=== CONT  TestAccECSCapacityProvider_managedScalingPartial
--- PASS: TestAccECSCapacityProvider_basic (35.24s)
=== CONT  TestAccECSCapacityProvider_managedScaling
--- PASS: TestAccECSCapacityProvider_managedScalingPartial (37.70s)
=== CONT  TestAccECSCapacityProvider_disappears
--- PASS: TestAccECSCapacityProvider_disappears (28.03s)
=== CONT  TestAccECSCapacityProvider_Identity_ExistingResource
--- PASS: TestAccECSCapacityProvider_managedScaling (66.59s)
=== CONT  TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
=== NAME  TestAccECSCapacityProvider_Identity_ExistingResource
    capacity_provider_identity_gen_test.go:238: Step 1/3 error: Post-apply refresh state check(s) failed:
        aws_ecs_capacity_provider.test - Identity found in state, and was not expected.
=== NAME  TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
    capacity_provider_identity_gen_test.go:317: Step 1/2 error: Post-apply refresh state check(s) failed:
        aws_ecs_capacity_provider.test - Identity found in state, and was not expected.
--- FAIL: TestAccECSCapacityProvider_Identity_ExistingResource (41.59s)
=== CONT  TestAccECSCapacityProvider_mutualExclusivity
--- PASS: TestAccECSCapacityProvider_mutualExclusivity (2.42s)
=== CONT  TestAccECSCapacityProvider_createManagedInstancesProvider_basic
--- FAIL: TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange (39.87s)
=== CONT  TestAccECSCapacityProvider_clusterFieldValidations
--- PASS: TestAccECSCapacityProvider_clusterFieldValidations (2.53s)
=== CONT  TestAccECSCapacityProvider_Identity_RegionOverride
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_basic (37.17s)
--- PASS: TestAccECSCapacityProvider_Identity_RegionOverride (55.98s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/ecs        358.319s
?       github.com/hashicorp/terraform-provider-aws/internal/service/ecs/test-fixtures  [no test files]
FAIL
make: *** [t] Error 1
...

@kg-aws kg-aws requested a review from a team as a code owner November 19, 2025 19:51
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@kg-aws kg-aws changed the title Managed instances infra optimization feat(ecs): Managed instances infra optimization Nov 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

⚠️ Our automation has detected the following potential issues with your pull request

❌ Changelog Entry Required (Click to expand)

The proposed change requires a changelog entry. Please see the Changelog Process section of the contributing guide for information on the changelog generation process.

Tip: This check is not triggered for draft pull requests, since the pull request number is not known until the pull request is opened and is required to create a changelog entry. Opening a pull request first as a draft, adding the requisite changelog entry file, and then marking the pull request as ready for review will prevent future warnings.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. size/L Managed by automation to categorize the size of a PR. labels Nov 19, 2025
@kg-aws kg-aws changed the title feat(ecs): Managed instances infra optimization feat(ecs): Managed Instances Infrastructure Optimization Nov 19, 2025
@ewbankkit
Copy link
Contributor

ewbankkit commented Nov 19, 2025 •
edited
Loading

Requires AWS SDK for Go v2 Release 2025-11-19: #45144.

@kg-aws kg-aws force-pushed the managed_instances_infra_optimization branch from e8d40c6 to 1579df7 Compare November 20, 2025 14:41
@kg-aws
Copy link
Contributor Author

kg-aws commented Nov 20, 2025 •
edited
Loading

Hi @ewbankkit - I am seeing 2 test failures in the latest test run. The failed tests are unrelated to this change but I am debugging why the failures.

edit-1: These failing test seems to be coming from an auto generated file. I am looking for some help to understand what's failing.

@ewbankkit ewbankkit added the partner Contribution from a partner. label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. service/ecs Issues and PRs that pertain to the ecs service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kg-aws @ewbankkit